chore: bump bb-storage to dc342e1 - #71
Merged
Merged
Conversation
Align the Go and Bazel bb-storage pins and pass the new zstd pool argument required by NewCASBlobAccessCreator.
ivangolub-oai
approved these changes
Mar 19, 2026
EdSchouten
reviewed
Mar 19, 2026
EdSchouten
left a comment
EdSchouten
left a comment
Member
There was a problem hiding this comment.
Can you please run this as well?
go get github.com/buildbarn.bb-storage@dc342e1799d72bd927ffc0af1f429e7044118b07
As in, make sure that go.mod remains in sync with MODULE.bazel.
EdSchouten
reviewed
Mar 19, 2026
| return util.StatusWrap(err, "Failed to create Push Authorizer from Configuration") | ||
| } | ||
|
|
||
| zstdPool := bb_zstd.NewPoolFromConfiguration(nil) |
Member
There was a problem hiding this comment.
Instead of doing this, can we please add a configuration option for the zstd pool, like we did here?
Contributor
Author
There was a problem hiding this comment.
mind taking another look?
Co-authored-by: Codex <noreply@openai.com>
EdSchouten
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the Go and Bazel bb-storage pins and pass the new zstd pool argument required by NewCASBlobAccessCreator.